Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-878562 - Release 1.6.0 #980

Merged
merged 3 commits into from
Jul 31, 2023
Merged

SNOW-878562 - Release 1.6.0 #980

merged 3 commits into from
Jul 31, 2023

Conversation

sfc-gh-anavalos
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #980 (fbf7035) into main (8471676) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head fbf7035 differs from pull request most recent head 5a2fe7f. Consider uploading reports for the commit 5a2fe7f to get more accurate results

@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
- Coverage   98.34%   98.32%   -0.02%     
==========================================
  Files          51       51              
  Lines        9298     9280      -18     
  Branches     1691     1686       -5     
==========================================
- Hits         9144     9125      -19     
  Misses         62       62              
- Partials       92       93       +1     
Files Changed Coverage Δ
src/snowflake/snowpark/version.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we do changelog review as well in this PR?

CHANGELOG.md Show resolved Hide resolved
@sfc-gh-stan
Copy link
Collaborator

I'm hoping to merge #964 before the release.

Copy link
Contributor

@sfc-gh-mabrennan sfc-gh-mabrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments about the changelog entries. Thanks.

@sfc-gh-stan
Copy link
Collaborator

I'm hoping to merge #964 before the release.

#964 is merged and I have rebased this branch.

@sfc-gh-kdama sfc-gh-kdama merged commit 9ccbd42 into main Jul 31, 2023
39 checks passed
@sfc-gh-kdama sfc-gh-kdama deleted the release-v1.6.0 branch July 31, 2023 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants