Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0 #1327

Closed
wants to merge 1 commit into from

Conversation

igneel64
Copy link
Contributor

Add schema for cross-domain, cross-platform, app-web/web-app navigations. This schema is going to be used in both web and mobile implementations. Also expecting enrich changes.

(close #1326)

@igneel64 igneel64 marked this pull request as draft August 22, 2023 09:47
@igneel64 igneel64 requested a review from matus-tomlein August 22, 2023 09:47
Copy link
Contributor

@matus-tomlein matus-tomlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igneel64 igneel64 force-pushed the issue/1326-add_cross_navigation_schema branch from 43b4f61 to 1e3b26a Compare August 22, 2023 11:14
@igneel64 igneel64 force-pushed the issue/1326-add_cross_navigation_schema branch from 1e3b26a to fa80b4c Compare November 13, 2023 10:43
@igneel64 igneel64 force-pushed the issue/1326-add_cross_navigation_schema branch from fa80b4c to 6fda89b Compare November 13, 2023 10:44
@igneel64 igneel64 marked this pull request as ready for review November 13, 2023 10:45
@igneel64 igneel64 requested a review from spenes November 13, 2023 10:45
Copy link
Contributor

@adatzer adatzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@spenes spenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matus-tomlein
Copy link
Contributor

Cherry picked to R152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add com.snowplowanalytics.snowplow/cross_navigation/jsonschema/1-0-0
4 participants