Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 155 #1392

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Release 155 #1392

merged 2 commits into from
Mar 11, 2024

Conversation

adatzer
Copy link
Contributor

@adatzer adatzer commented Mar 8, 2024

No description provided.

@adatzer adatzer requested a review from colmsnowplow March 8, 2024 05:51
"properties": {
"x-gtm-server-preview": {
"type": "string",
"description": "The X-Gtm-Server-Preview HTTP header value",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention that this stores the full header, or just the key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the value

Copy link
Contributor

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm assuming you've validated it's a specific value of fixed length that fits within 256 bytes ofc.

@colmsnowplow colmsnowplow requested a review from jbeemster March 11, 2024 12:25
@jbeemster jbeemster force-pushed the feat/gtmss_preview_header branch from 4bbb36d to 8921bfe Compare March 11, 2024 18:49
@jbeemster jbeemster changed the title Feat/gtmss_preview_header Release 155 Mar 11, 2024
@jbeemster jbeemster merged commit 577eeb1 into master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants