Skip to content

Commit

Permalink
Remove unnecessary default of the 0 value
Browse files Browse the repository at this point in the history
  • Loading branch information
colmsnowplow committed Nov 12, 2024
1 parent 5d075d3 commit b866b5a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkg/source/pubsub/pubsub_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ func (f adapter) ProvideDefault() (interface{}, error) {
cfg := &Configuration{
// ConcurrentWrites: 50,
// Default is now handled in newPubsubSource, until we make a breaking release.
MaxOutstandingMessages: 1000,
MaxOutstandingBytes: 1e9,
MinExtensionPeriodSeconds: 0, // Default of 0 preserves client's default behaviour
MaxOutstandingMessages: 1000,
MaxOutstandingBytes: 1e9,
// StreamingPullGoRoutines: 1,
// Similarly handled in newPubsubSource - when we make a breaking release this should be the default.
}
Expand Down

0 comments on commit b866b5a

Please sign in to comment.