Add expiry config + base64 validation to the GTM SS preview header transformation #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
force-pushed
the
gtmss_validation
branch
2 times, most recently
from
4fbefc7 to
9c85766
Compare
pondzix
changed the title
| @@ -30,6 +34,7 @@ func TestGTMSSPreview(t *testing.T) { | |||
| Ctx: "contexts_com_google_tag-manager_server-side_preview_mode_1", | |||
| Property: "x-gtm-server-preview", | |||
| HeaderKey: "x-gtm-server-preview", | |||
| Expiry: fiftyYears, | |||
There was a problem hiding this comment.
2069 devs be like "why my test failing?" :D
There was a problem hiding this comment.
in 2069 I'm an actual senior engineer and I can help!
colmsnowplow
approved these changes
Sep 18, 2024
pondzix
force-pushed
the
gtmss_validation
branch
from
9c85766 to
fd4bb9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira ref: PDP-1435