-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add E2E latency metrics #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
force-pushed
the
e2e_latency_metric
branch
3 times, most recently
from
November 13, 2024 08:42
94fff43
to
6ef2bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a couple of comments to sort out - let me know if any of them are worth a chat.
colmsnowplow
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pondzix
New E2E latency is calculated based on `collector_tstamp` field coming from Snowplow enriched data. It means E2E can be obtain from valid Snowplow events: `E2E latency = (target write timestamp) - (collector timestamp)` E2E metric can be enabled/disabled using new top-level confgiuration option `metrics.enable_e2e_latency`
pondzix
force-pushed
the
e2e_latency_metric
branch
from
November 13, 2024 13:57
d050809
to
8141e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: PDP-1549
New E2E latency is calculated based on
collector_tstamp
field coming from Snowplow enriched data. It means E2E can be obtain from valid Snowplow events:E2E latency = (target write timestamp) - (collector timestamp)
E2E metric can be enabled/disabled using new top-level confgiuration option
metrics.enable_e2e_latency