Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E latency metrics #379

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add E2E latency metrics #379

merged 1 commit into from
Nov 13, 2024

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Nov 11, 2024

ref: PDP-1549

New E2E latency is calculated based on collector_tstamp field coming from Snowplow enriched data. It means E2E can be obtain from valid Snowplow events:

E2E latency = (target write timestamp) - (collector timestamp)

E2E metric can be enabled/disabled using new top-level confgiuration option metrics.enable_e2e_latency

@pondzix pondzix force-pushed the e2e_latency_metric branch 3 times, most recently from 94fff43 to 6ef2bc2 Compare November 13, 2024 08:42
Copy link
Collaborator

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a couple of comments to sort out - let me know if any of them are worth a chat.

@pondzix pondzix requested a review from colmsnowplow November 13, 2024 11:59
Copy link
Collaborator

@colmsnowplow colmsnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pondzix

New E2E latency is calculated based on `collector_tstamp` field coming from Snowplow enriched data. It means E2E can be obtain from valid Snowplow events:

`E2E latency = (target write timestamp) - (collector timestamp)`

E2E metric can be enabled/disabled using new top-level confgiuration option `metrics.enable_e2e_latency`
@pondzix pondzix merged commit 8141e97 into develop Nov 13, 2024
1 check passed
@pondzix pondzix deleted the e2e_latency_metric branch November 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants