Add option to set kinsumer client name #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestClientNamePassThrough(t *testing.T) { |
There was a problem hiding this comment.
What's the purpose of this additional test? What does it provide that isn't included in the other test?
Can its purpose be documented in a comment?
There was a problem hiding this comment.
Discussed on call - the test above does all we need, we can remove this one.
| t.Fatalf("failed to CreateComponent with error: %q", err.Error()) | ||
| } | ||
|
|
||
| // workaround since clientName is unexported by Kinsumer |
There was a problem hiding this comment.
Not asking you to implement anything, but have a think about other possible options to verify the feature, and when we catch up let's think about what the simplest options might be.
There was a problem hiding this comment.
Followup - we discussed different ways of thinking on the call.
adatzer
force-pushed
the
feat/kinsumer_client_name
branch
from
1653f96 to
2baf306
Compare
adatzer
force-pushed
the
feat/kinsumer_client_name
branch
from
2baf306 to
212b3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ref: PDP-1581