Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart to fetch dataset name list when connection is lost #272

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Restart to fetch dataset name list when connection is lost #272

merged 4 commits into from
Apr 3, 2024

Conversation

BECATRUE
Copy link
Member

@BECATRUE BECATRUE commented Apr 3, 2024

This closes #269.

When the connection is lost, the "restart" button is enabled.

@BECATRUE BECATRUE added the enhancement New feature or any improvements to codes label Apr 3, 2024
@BECATRUE BECATRUE self-assigned this Apr 3, 2024
@BECATRUE BECATRUE requested a review from kangz12345 as a code owner April 3, 2024 08:58
@kangz12345
Copy link
Member

Please resolve the conflicts!

@BECATRUE
Copy link
Member Author

BECATRUE commented Apr 3, 2024

I knew there was going to be a conflict while implementing this😂

@BECATRUE
Copy link
Member Author

BECATRUE commented Apr 3, 2024

A Pylint warning occurs because there are similar codes checking if the websocket connection is valid.

Maybe we are going to implement a base class for QThread connecting to ARTIQ-PROXY later, so is it okay to disable this warning temporarily?

@kangz12345
Copy link
Member

A Pylint warning occurs because there are similar codes checking if the websocket connection is valid.

Maybe we are going to implement a base class for QThread connecting to ARTIQ-PROXY later, so is it okay to disable this warning temporarily?

Okay, then please create an issue about this and disable the warning for now.

@BECATRUE BECATRUE mentioned this pull request Apr 3, 2024
Open
@BECATRUE BECATRUE force-pushed the BECATRUE/269/restart-fetching-dataset-list branch from 94b8eee to 39f760d Compare April 3, 2024 11:24
@BECATRUE BECATRUE mentioned this pull request Apr 3, 2024
Merged
@BECATRUE BECATRUE force-pushed the BECATRUE/269/restart-fetching-dataset-list branch from 39f760d to f6ab306 Compare April 3, 2024 11:34
@BECATRUE
Copy link
Member Author

BECATRUE commented Apr 3, 2024

To solve the duplicate-code Pylint warning, the forced-push could not be avoided. Please understand.

kangz12345
kangz12345 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kangz12345 kangz12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BECATRUE BECATRUE merged commit d75120b into develop Apr 3, 2024
8 checks passed
@BECATRUE BECATRUE deleted the BECATRUE/269/restart-fetching-dataset-list branch April 3, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangz12345 kangz12345 kangz12345 approved these changes

Assignees

@BECATRUE BECATRUE

Labels
enhancement New feature or any improvements to codes
Projects
Data viewer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart fetching dataset name list in realtime part when the connection is lost
2 participants
@BECATRUE @kangz12345