StageWidget to monitor and control each motorized stage
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved the pylint warning.
BECATRUE
requested changes
Apr 4, 2024
| Args: | ||
| open_: True for open, False for closed. | ||
| """ | ||
| self._inner.setEnabled(open_) |
Applied the review.
BECATRUE
reviewed
Apr 4, 2024
| self.absoluteBox = QDoubleSpinBox(self) | ||
| self.absoluteBox.setButtonSymbols(QAbstractSpinBox.NoButtons) | ||
| self.absoluteBox.setDecimals(3) | ||
| self.absoluteBox.setSingleStep(0.001) |
There was a problem hiding this comment.
Is there any reason to set its single step even if there is no button?
There was a problem hiding this comment.
We can adjust the value by scrolling mouse wheel or pressing keyboard arrow keys.
I removed the buttons to save space.
There was a problem hiding this comment.
Oh, I forgot we can adjust it without clicking the button directly.
Then, please never mind😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates some features added in #248 and introduces an individual stage controller widget without signal connection.
The next PR will be a qiwis app using this widget.
See also: #245.