Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug when changing the remote mode rapidly #278

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

BECATRUE
Copy link
Member

@BECATRUE BECATRUE commented Apr 5, 2024

This resolved #277.

As I tested, there is a slight delay when scrolling rapidly.
However, it seems to be allowed and moderately efficient.

@BECATRUE BECATRUE added the bug Something isn't working label Apr 5, 2024
@BECATRUE BECATRUE self-assigned this Apr 5, 2024
@BECATRUE BECATRUE requested a review from kangz12345 as a code owner April 5, 2024 09:29
@kangz12345
Copy link
Member

This solution has a problem, right?

@BECATRUE
Copy link
Member Author

BECATRUE commented Apr 7, 2024

Didn't this PR resolve the problem? Did you mean it has another problem? @kangz12345

@kangz12345
Copy link
Member

Oh so this is the final solution, okay I misunderstood.

Copy link
Member

@kangz12345 kangz12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the delay but maybe it will not be a big problem. Let's fix it later if it is!

@BECATRUE
Copy link
Member Author

BECATRUE commented Apr 7, 2024

This problem may bother you a little bit, but at least it doesn't kill the GUI, so let's fix it later.

@BECATRUE BECATRUE merged commit 4c3ccb0 into develop Apr 7, 2024
8 checks passed
@BECATRUE BECATRUE deleted the BECATRUE/277/bug-when-changing-remote-mode branch April 7, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Error when changing time or rid rapidly (dataviewer remote)
2 participants