Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage controller app #285

Merged
merged 11 commits into from
Apr 8, 2024
Merged

Stage controller app #285

merged 11 commits into from
Apr 8, 2024

Conversation

kangz12345
Copy link
Member

This closes #245, implementing the motorized stage controller app.

Key structure of this app:

  • It uses a dedicated non-GUI QThread to actually control the stage RPC clients.
  • StageManager lives in the non-GUI thread, and provides signals to control the RPC clients.
  • StageProxy provides a convenient interface to control the RPC clients which live in a different thread (automatically converts method calls to signal emissions).
  • Every proxied RPC call is non-blocking.

Probable issues:

  1. There is no way to restart the manager thread if it crashes somehow. However the RPC errors will not cause such crash.
  2. The move requests are non-blocking so rapid move requests interrupts the previous moves and even the server does not protect it, i.e., it does not wait for the previous move to be done. For example, when the relative move button is rapidly clicked 5 times with step size of 1um, it may actually move less than 5um.

Screen Shot 2024-04-07 at 16 56 27

@kangz12345 kangz12345 added the enhancement New feature or any improvements to codes label Apr 7, 2024
@kangz12345 kangz12345 self-assigned this Apr 7, 2024
@kangz12345 kangz12345 requested a review from BECATRUE as a code owner April 7, 2024 08:10
@kangz12345 kangz12345 mentioned this pull request Apr 7, 2024
Closed
3 tasks
BECATRUE
BECATRUE requested changes Apr 7, 2024
View reviewed changes
Copy link
Member

@BECATRUE BECATRUE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any plan to use StageManager.clear signal? I'm just curious!

iquip/apps/stage.py Outdated Show resolved Hide resolved
iquip/apps/stage.py Outdated Show resolved Hide resolved
iquip/apps/stage.py Outdated Show resolved Hide resolved
iquip/apps/stage.py Outdated Show resolved Hide resolved
iquip/apps/stage.py
else:
widget.setPosition(position_m)

def __del__(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@kangz12345
Simplify the code
95b9985 
Applied the reivew.
@kangz12345
Add attributes docstring of StageControllerApp
2a5ed0f 
Applied the review.
@kangz12345
Fix typo
e426556 
Applied the review.
@kangz12345
Add missing argument
936fee3 
Applied the review.
@kangz12345 kangz12345 requested a review from BECATRUE April 8, 2024 03:36
BECATRUE
BECATRUE approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@BECATRUE BECATRUE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangz12345 kangz12345 merged commit b4422f0 into develop Apr 8, 2024
8 checks passed
@kangz12345 kangz12345 deleted the kangz12345/245/stage-app branch April 8, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BECATRUE BECATRUE BECATRUE approved these changes

Assignees

@kangz12345 kangz12345

Labels
enhancement New feature or any improvements to codes
Projects
Device Monitors
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Motorized stage monitor
2 participants
@kangz12345 @BECATRUE