-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop
to release
for v1.0.0
#291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong way to define a decorator with arguments.
1. Implement RangeScan widget. 2. Add codes for sending scan arguments to artiq proxy.
This reverts commit c9c2e94.
This closes #283. Now, the visualization checkbox in builder app is removed. <img width=200 src="https://github.com/snu-quiqcl/iquip/assets/76851886/4dec444f-b85f-4bd3-8e2d-8cf24cc49549">
This resolved #277. As I tested, there is a slight delay when scrolling rapidly. However, it seems to be allowed and moderately efficient.
Applied the reivew.
Applied the review.
Applied the review.
This closes #287. This PR is perfectly compatible to snu-quiqcl/qiwis#250, so in the current QIWIS version, the background and icon may look strange (e.g., scale, ratio). ### Background ![image](https://github.com/snu-quiqcl/iquip/assets/76851886/c07f504f-aac0-4737-8e04-a4c44d9599ad) ### Icon <img width=600 src="https://github.com/snu-quiqcl/iquip/assets/76851886/b08162c5-d834-4e7d-a46b-b8d17578be24">
This closes #286. After merged, I will release the first official version, v1.0.0.
kangz12345
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #289.