Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max-positional-arguments=10 in pylintrc #319

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add max-positional-arguments=10 in pylintrc #319

merged 1 commit into from
Oct 30, 2024

Conversation

kangz12345
Copy link
Member

@kangz12345 kangz12345 commented Oct 29, 2024 •
edited
Loading

This is a work-around for #318. I think we should update the codes later for better design.

@kangz12345 kangz12345 added the enhancement New feature or any improvements to codes label Oct 29, 2024
@kangz12345 kangz12345 self-assigned this Oct 29, 2024
@kangz12345 kangz12345 requested a review from BECATRUE as a code owner October 29, 2024 08:43
@kangz12345 kangz12345 linked an issue Oct 29, 2024 that may be closed by this pull request
Updated pylint complains about the number of positional arguments #318
Open
BECATRUE
BECATRUE requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@BECATRUE BECATRUE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

However, this is not an ultimate solution but just a temporary detour, so how about removing the "resolve" keyword in the PR explanation?

@BECATRUE BECATRUE mentioned this pull request Oct 30, 2024
Merged
@kangz12345 kangz12345 removed a link to an issue Oct 30, 2024
Updated pylint complains about the number of positional arguments #318
Open
@kangz12345 kangz12345 requested a review from BECATRUE October 30, 2024 01:51
@BECATRUE BECATRUE merged commit 1904f39 into develop Oct 30, 2024
6 checks passed
@BECATRUE BECATRUE deleted the kangz12345/318/update-pylintrc branch October 30, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BECATRUE BECATRUE BECATRUE approved these changes

Assignees

@kangz12345 kangz12345

Labels
enhancement New feature or any improvements to codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangz12345 @BECATRUE