Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: incremental scanning support [IDE-275] #52

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Jun 3, 2024

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

  • Tests added and all succeed
  • Linted
  • README.md updated, if user-facing

🚨After having merged, please update the snyk-ls and CLI go.mod to pull in latest client.

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner June 3, 2024 09:39
@CLAassistant
Copy link

CLAassistant commented Jun 3, 2024

CLA assistant check
All committers have signed the CLA.

@bastiandoetsch bastiandoetsch marked this pull request as draft June 3, 2024 09:52
@bastiandoetsch bastiandoetsch marked this pull request as ready for review June 4, 2024 15:50
@github-actions github-actions bot added feature and removed feature labels Jun 4, 2024
@bastiandoetsch bastiandoetsch force-pushed the feat/IDE-275_Implement-changes-for-incremental-scanning-support branch from 300639a to 9617679 Compare June 5, 2024 06:09
Copy link
Contributor

@teodora-sandu teodora-sandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments but looks good! We can test it together when we pair and discuss these things I brought up in the review

internal/analysis/analysis.go Show resolved Hide resolved
internal/analysis/analysis.go Outdated Show resolved Hide resolved
internal/analysis/analysis.go Show resolved Hide resolved
Copy link
Contributor

@teodora-sandu teodora-sandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested it in VSCode and works too ⭐

@bastiandoetsch bastiandoetsch merged commit 83581fd into main Jun 5, 2024
10 of 12 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/IDE-275_Implement-changes-for-incremental-scanning-support branch June 5, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants