Add image pull secrets, so that private registries can be used ex art… #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ifactory
What this does
This PR updates the snyke-monitor Helm chart to include imagePullSecrets configuration. This enhancement allows for the use of private image registries or pull-through registries, ensuring a more secure and flexible image pulling process.
Notes for the reviewer
Context: The addition of imagePullSecrets to the snyke-monitor Helm chart is intended to facilitate deployments that use private or pull-through registries, addressing a common need in various deployment scenarios.
Location of Changes: Primary modifications can be found in the values.yaml file and the corresponding deployment templates where the imagePullSecrets configuration is added.
Testing Considerations: It would be beneficial to test the Helm chart in an environment that requires access to a private registry. The goal is to ensure successful image pulls when the correct imagePullSecrets is provided.
Backward Compatibility: The additions have been designed to be optional. In scenarios where no imagePullSecrets are specified, the behavior remains consistent with previous versions, thus maintaining backward compatibility.
Screenshots
Visuals that may help the reviewer