Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: streamline .dcignore to exclude common build dirs [HEAD-1006] #253

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

cat2608
Copy link
Contributor

@cat2608 cat2608 commented Dec 4, 2023

Description

Simplify the .dcignore removing specific and potentially unnecessary exclusions. This change is intended to avoid the accidental exclusion of important project files.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from b8a7edb to 5f7822b Compare December 4, 2023 14:37
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 4, 2023 14:37 — with GitHub Actions Inactive
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 4, 2023 15:46 — with GitHub Actions Inactive
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 5, 2023 09:35 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from ee2ed67 to 5cd2417 Compare December 5, 2023 11:16
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 5, 2023 11:16 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from 5cd2417 to ce0aadb Compare December 5, 2023 12:23
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 5, 2023 12:23 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from ce0aadb to 4fc4948 Compare December 6, 2023 10:48
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 6, 2023 10:48 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from 4fc4948 to df6d0ca Compare December 6, 2023 11:07
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from df6d0ca to f7ff6af Compare December 6, 2023 11:11
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 6, 2023 11:11 — with GitHub Actions Inactive
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 06:25 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from f7ff6af to bef50e0 Compare December 7, 2023 06:51
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 06:51 — with GitHub Actions Inactive
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 07:20 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from bef50e0 to 9bca230 Compare December 7, 2023 08:51
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 08:51 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from 9bca230 to 2d82028 Compare December 7, 2023 09:23
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 09:23 — with GitHub Actions Inactive
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from 2d82028 to 16bf97a Compare December 7, 2023 09:43
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 09:43 — with GitHub Actions Inactive
Simplify the `.dcignore` removing specific and potentially unnecessary exclusions.
@cat2608 cat2608 force-pushed the fix/HEAD-1006-fix-dcignore branch from 16bf97a to 41c51b6 Compare December 7, 2023 10:01
@cat2608 cat2608 temporarily deployed to snyk-msbuild-envs December 7, 2023 10:01 — with GitHub Actions Inactive
@cat2608 cat2608 marked this pull request as ready for review December 7, 2023 10:01
@cat2608 cat2608 requested a review from a team as a code owner December 7, 2023 10:01
@cat2608 cat2608 merged commit 62ba050 into main Dec 7, 2023
2 checks passed
@cat2608 cat2608 deleted the fix/HEAD-1006-fix-dcignore branch December 7, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants