Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with the python example contained in the installation directory #1

Open
wants to merge 65 commits into
base: devel
Choose a base branch
from

Commits on Feb 11, 2019

  1. MKL compliant code

    to mimic the instructions from RNP::Eigensystem in file Eigensystems.cpp  because MKL lapack cannot handle NULL pointer for the matrix 	RNP::Eigensystem(n2, NULL, n2, q, NULL, 1, phi, n2, work_, NULL, lwork); //M.P
    sajidmc authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    c826564 View commit details
    Browse the repository at this point in the history
  2. Purdue HPC compliant make files

    please edit for the library locations first
    sajidmc authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    d29c656 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e2ed5e7 View commit details
    Browse the repository at this point in the history
  4. Update PythonTest.py

    fixed bug of undeclared variable
    sajidmc authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    57eacbc View commit details
    Browse the repository at this point in the history
  5. example figure

    sajidmc authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    66dc25e View commit details
    Browse the repository at this point in the history
  6. Update README

    sajidmc authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    2cb92b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Configuration menu
    Copy the full SHA
    5c8c9d5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' of https://github.com/sajidmc/S4

    Sajid Choudhury committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    1326092 View commit details
    Browse the repository at this point in the history
  3. Update README

    sajidmc authored Feb 12, 2019
    Configuration menu
    Copy the full SHA
    6e3113f View commit details
    Browse the repository at this point in the history
  4. Update README

    sajidmc authored Feb 12, 2019
    Configuration menu
    Copy the full SHA
    f677db2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Merge pull request #4 from soamaven/devel

    Fix SpectrumSampler in Python extension
    phoebe-p authored Jul 12, 2019
    Configuration menu
    Copy the full SHA
    f7af464 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    501df26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b914507 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2019

  1. Update README

    phoebe-p authored Jul 28, 2019
    Configuration menu
    Copy the full SHA
    0fa13cd View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2019

  1. Update README

    phoebe-p authored Jul 29, 2019
    Configuration menu
    Copy the full SHA
    011c068 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Configuration menu
    Copy the full SHA
    bce9c42 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. Configuration menu
    Copy the full SHA
    e95884a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3 from sajidmc/master

    Added HPC compliant make file MakefileHPC
    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    d10717a View commit details
    Browse the repository at this point in the history
  3. Update README

    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    9ff7e1e View commit details
    Browse the repository at this point in the history
  4. Update README

    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    2ab8224 View commit details
    Browse the repository at this point in the history
  5. Update README

    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    0a74f1f View commit details
    Browse the repository at this point in the history
  6. Rename README to README.md

    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    8db930b View commit details
    Browse the repository at this point in the history
  7. Update README.md

    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    ce899b8 View commit details
    Browse the repository at this point in the history
  8. Update README.md

    phoebe-p authored Aug 15, 2019
    Configuration menu
    Copy the full SHA
    c7b9882 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Update MacOS/OSX Makefile to include fftw and suitesparse libraries, …

    …assuming installation via Homebrew
    phoebe-p committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    08aaebf View commit details
    Browse the repository at this point in the history
  2. Update MacOS/OSX Makefile to include fftw and suitesparse libraries, …

    …assuming installation via Homebrew (fix typo)
    phoebe-p committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    d89d4b7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7320712 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    05cd540 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Update README.md

    phoebe-p authored Oct 14, 2020
    Configuration menu
    Copy the full SHA
    4c26146 View commit details
    Browse the repository at this point in the history
  2. Update README.md

    phoebe-p authored Oct 14, 2020
    Configuration menu
    Copy the full SHA
    9cffe4f View commit details
    Browse the repository at this point in the history
  3. Update README.md

    phoebe-p authored Oct 14, 2020
    Configuration menu
    Copy the full SHA
    c37ae14 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. This commit significantly changes the behaviour of the Lanczos smooth…

    …ing parameters.
    
    ‘mp1’ is proportional to the ’Width’ option​. ’Jinc’ calculates J1(2 π z)/(π z) where z is the argument passed into the function. The Bessel function itself is 0 at z = 0, but because of the division by π z is 1 when the argument z is zero.​ ‘fr’ is calculated from the G-vectors describing the different diffraction orders in reciprocal space and is thus of the same order of magnitude as the G-vectors, which have an order of magnitude of 1/(length scale of unit cell), so if everything is specified in nm, a typical unit cell of e.g. 500 nm gives: 1/500 = order of 1 x 10-3. So in this case, the argument going into the Jinc function will always be << 1; the numerator (fr) is of the order 1 x 10-3, and is always divided by at least 1 because the denominator is ‘2*mp1 + 1’. This means the Bessel function always returns 1, or something extremely close to 1 (so the ‘power’ parameter, which just takes the calculated smoothing factor and raises it to the power specified, also does nothing, because 1 to any power is still 1). This meant that regardless of which options you choose to pass for LanczosSmoothing, nothing really happens, because all you are doing is pre-multiplying things by 1.​ In any case, the inclusion of the constant ‘1’ makes no sense to me because it clearly ruins the scale-insensitivity of the implementation. I “fixed” the problem by simply removing the ‘+1’. This seems like a minor change but it significantly affects the behaviour of the LanczosSmoothing parameters passed to S4.
    phoebe-p committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    69aac7a View commit details
    Browse the repository at this point in the history
  2. merge

    phoebe-p committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d4fb979 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Update README.md

    phoebe-p authored Oct 12, 2021
    Configuration menu
    Copy the full SHA
    37999d5 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Configuration menu
    Copy the full SHA
    394d523 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #7 from phoebe-p/implicit_dec_error

    remove lines causing implicit function declaration errors
    phoebe-p authored Dec 21, 2021
    Configuration menu
    Copy the full SHA
    2088f8c View commit details
    Browse the repository at this point in the history
  3. Update README.md

    phoebe-p authored Dec 21, 2021
    Configuration menu
    Copy the full SHA
    ee52adb View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Configuration menu
    Copy the full SHA
    069a795 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b1d10c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #8 from phoebe-p/M1_Makefile

    Add Apple M1 makefile
    phoebe-p authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0e44001 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. create Makefile.test

    checking which flags are necessary for compilation
    phoebe-p authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    247bac9 View commit details
    Browse the repository at this point in the history
  2. update makefile.test

    phoebe-p authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    937b040 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    c535c80 View commit details
    Browse the repository at this point in the history
  2. Update Makefile.aarch64

    phoebe-p authored Feb 1, 2023
    Configuration menu
    Copy the full SHA
    22b8f4f View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Update README.md

    phoebe-p authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ad4f128 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    1b00106 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f666278 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2acf971 View commit details
    Browse the repository at this point in the history
  4. try to fix boost issue

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d669d46 View commit details
    Browse the repository at this point in the history
  5. try to fix boost issue

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    d2bf1f8 View commit details
    Browse the repository at this point in the history
  6. try to fix boost issue

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a1ee39e View commit details
    Browse the repository at this point in the history
  7. try to fix boost issue

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    b52efa8 View commit details
    Browse the repository at this point in the history
  8. try to fix boost issue

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    c8cc536 View commit details
    Browse the repository at this point in the history
  9. try to fix boost issue

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    2486a8a View commit details
    Browse the repository at this point in the history
  10. new Mac (intel) makefile

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    530abeb View commit details
    Browse the repository at this point in the history
  11. new Mac (intel) makefile

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    527a039 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2f8afee View commit details
    Browse the repository at this point in the history
  13. update mac_intel Makefile

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4b67fee View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    cd2653e View commit details
    Browse the repository at this point in the history
  15. try M1 with clang

    phoebe-p committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    f076f15 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Fixed S4 build for macOS on arm64

    phoebe-p authored and Luigi Giugliano committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    dd383c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9047f22 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge pull request #9 from Abelarm/devel

    Fixed S4 build for macOS-arm64
    phoebe-p authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a15f9e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Rename interpolator (#10)

    * avoid variable name I in Interpolator.h and main_python.c
    phoebe-p authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8aa265b View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    c1b8357 View commit details
    Browse the repository at this point in the history