video subtitles: try with mux-hosted subtitles #984
Conversation
mdumond
requested review from
andrashee,
mkue,
ssandino and
socialincome-dev
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis pull request updates video subtitle references in localization JSON files for multiple languages (German, English, French, and Italian). The changes replace local relative paths with absolute URLs pointing to video subtitles hosted on a streaming service (Mux). Each language-specific file has its Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
shared/locales/it/website-home.json (1)
23-23: LGTM! Consider documenting the Mux video ID.The Italian subtitle URL is consistent with other languages. Consider adding a comment in the JSON files to document the Mux video ID for future reference.
{ + // Mux video ID: IPdwilTUVkKs2nK8zKZi5eKwbKhpCWxgsYNVxcANeFE "metadata": {shared/locales/fr/website-home.json (1)
23-23: Consider adding a fallback mechanism.Consider implementing a fallback mechanism in case the Mux-hosted subtitles become temporarily unavailable.
Would you like me to propose a fallback implementation that could handle Mux service disruptions?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
shared/locales/de/website-home.json(1 hunks)shared/locales/en/website-home.json(1 hunks)shared/locales/fr/website-home.json(1 hunks)shared/locales/it/website-home.json(1 hunks)
🔇 Additional comments (3)
shared/locales/en/website-home.json (1)
23-23: LGTM! Verify subtitle URL accessibility.
The change from local to Mux-hosted subtitles is consistent with other language files.
✅ Verification successful
Subtitle URL is accessible and properly configured
The Mux-hosted subtitle URL returns a 200 status code with proper CORS headers and content configuration, confirming its accessibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that all subtitle URLs are accessible
echo "Checking subtitle URLs accessibility..."
curl -I "https://stream.mux.com/IPdwilTUVkKs2nK8zKZi5eKwbKhpCWxgsYNVxcANeFE/text/e4IuMXCAcXeGaFiskrAlXSEXIvAZXkugk3UweHfU9thkgNjaAGtdlw.vtt"
Length of output: 1385
shared/locales/de/website-home.json (1)
23-23: LGTM! Consistent with English localization.
The German subtitle URL uses the same Mux video ID with a language-specific text track.
shared/locales/fr/website-home.json (1)
23-23: Verify Mux URL accessibility and consistency.
Let's ensure the URL is accessible and consistent with other language files.
✅ Verification successful
Mux video subtitle URLs are consistent across all language files
All language files (de, en, fr, it) reference the same Mux video ID IPdwilTUVkKs2nK8zKZi5eKwbKhpCWxgsYNVxcANeFE with language-specific subtitle tracks, indicating proper implementation.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check URL consistency across language files
echo "Checking subtitle URLs across all language files..."
for lang in de en fr it; do
echo "=== $lang ==="
if [[ -f "shared/locales/$lang/website-home.json" ]]; then
jq -r '."video-subtitle"' "shared/locales/$lang/website-home.json"
fi
done
Length of output: 1318
|
Visit the preview URL for this PR (updated for commit 71c9f0d): https://si-admin-staging--pr984-video-subtitles-2zmlsnge.web.app (expires Sat, 21 Dec 2024 14:34:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
|
@mdumond 🙌🏼 Safari shows now in DE the EN subtitles. |
Summary by CodeRabbit
New Features
Bug Fixes