-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: Cleaning up content for surveys #994
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe changes focus on refining the localization JSON for a website survey. The modifications involve simplifying existing keys, removing redundant qualifiers, and adding new descriptive keys to provide clearer context for survey questions. The updates aim to enhance the clarity and readability of the survey's language by separating titles from detailed descriptions and streamlining spending category labels. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
shared/locales/en/website-survey.json (1)
97-105
: Consider formatting the spending description for better readability.While moving detailed descriptions into a single field is good, the text could be more readable.
Consider this format:
- "spendingDescV1": "Education includes school fees, stationary, textbooks etc. Food includes for you or your household. Housing includes rent, house maintenance etc. Health care includes doctor, hospital visit, medicine etc. Transportation includes bus, taxi, poda poda, keke etc. Saving for the future includes saving it in a bank account or on a mobile money account etc. Investment includes fertilizers, tools, diesel for machinery etc.", + "spendingDescV1": "Categories include:\n- Education: school fees, stationary, textbooks\n- Food: for you or your household\n- Housing: rent, house maintenance\n- Health care: doctor, hospital visit, medicine\n- Transportation: bus, taxi, poda poda, keke\n- Saving for the future: bank account, mobile money account\n- Investment: fertilizers, tools, diesel for machinery",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
shared/locales/en/website-survey.json
(2 hunks)
🔇 Additional comments (2)
shared/locales/en/website-survey.json (2)
45-45
: LGTM! Good separation of location name and description.
The change appropriately moves the Freetown reference into the description, making the location choices clearer and more consistent.
Also applies to: 47-47
87-91
: Verify currency code consistency.
Good separation of the monetary threshold into description fields. However, let's ensure the currency code "SLE" is used consistently throughout the codebase.
✅ Verification successful
Currency code "SLE" is used consistently throughout the codebase
The search results confirm that the currency code "SLE" is used consistently in all monetary references across the localization files. The code appears in:
- Common translations (
common.json
) defining "SLE" as "Sierra Leonean Leone" - Survey questions with monetary thresholds (e.g., "SLE 500" in
website-survey.json
) - Translations in multiple languages (en, fr, it, kri) maintaining the same format
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any inconsistent currency code usage
rg -i "sle|leone" --type json
Length of output: 48511
Visit the preview URL for this PR (updated for commit bfeda1a): https://si-admin-staging--pr994-sandino-survey-clean-p3fgdxfj.web.app (expires Tue, 07 Jan 2025 17:18:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676 |
Summary by CodeRabbit