Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve emit types #4817

Merged
merged 13 commits into from
Oct 11, 2023
Merged

improve emit types #4817

merged 13 commits into from
Oct 11, 2023

Commits on Sep 2, 2023

  1. improve emit types

    ZachHaber committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    e285439 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Align broadcast emits with multiple arguments to reality

    Broadcast emits only return a single ack value
    ZachHaber committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    72a9624 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    59254e0 View commit details
    Browse the repository at this point in the history
  2. Remove emitWithAck from server and namespace

    Improve type definitions of `emit` and `emitWithAck` to prevent uses in an incorrect manner
    ZachHaber committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    11d4b61 View commit details
    Browse the repository at this point in the history
  3. convert tsd's expectError uses to ts-expect-error

    This avoids having tons of red squiggles showing on the IDE for a succeeding test
    tsd will still error out if a `ts-expect-error` goes unused, so it functionally is about the same
    ZachHaber committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7babe9a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5aa03c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    c188ab6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    a01899f View commit details
    Browse the repository at this point in the history
  2. switch socket.io.test-d.ts to testing lib instead of dist

    This makes DX nicer as typescript will show errors in the file as you work, instead of requiring compilation steps
    ZachHaber committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    0650f19 View commit details
    Browse the repository at this point in the history
  3. remove unused import

    ZachHaber committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1e74f22 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de96dc9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6cf63e9 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Configuration menu
    Copy the full SHA
    b0ffab7 View commit details
    Browse the repository at this point in the history