-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve emit types #4817
Merged
Merged
improve emit types #4817
Commits on Sep 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e285439 - Browse repository at this point
Copy the full SHA e285439View commit details
Commits on Sep 13, 2023
-
Align broadcast emits with multiple arguments to reality
Broadcast emits only return a single ack value
Configuration menu - View commit details
-
Copy full SHA for 72a9624 - Browse repository at this point
Copy the full SHA 72a9624View commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 59254e0 - Browse repository at this point
Copy the full SHA 59254e0View commit details -
Remove emitWithAck from server and namespace
Improve type definitions of `emit` and `emitWithAck` to prevent uses in an incorrect manner
Configuration menu - View commit details
-
Copy full SHA for 11d4b61 - Browse repository at this point
Copy the full SHA 11d4b61View commit details -
convert tsd's expectError uses to
ts-expect-error
This avoids having tons of red squiggles showing on the IDE for a succeeding test tsd will still error out if a `ts-expect-error` goes unused, so it functionally is about the same
Configuration menu - View commit details
-
Copy full SHA for 7babe9a - Browse repository at this point
Copy the full SHA 7babe9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa03c1 - Browse repository at this point
Copy the full SHA 5aa03c1View commit details
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c188ab6 - Browse repository at this point
Copy the full SHA c188ab6View commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a01899f - Browse repository at this point
Copy the full SHA a01899fView commit details -
switch socket.io.test-d.ts to testing lib instead of dist
This makes DX nicer as typescript will show errors in the file as you work, instead of requiring compilation steps
Configuration menu - View commit details
-
Copy full SHA for 0650f19 - Browse repository at this point
Copy the full SHA 0650f19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e74f22 - Browse repository at this point
Copy the full SHA 1e74f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for de96dc9 - Browse repository at this point
Copy the full SHA de96dc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cf63e9 - Browse repository at this point
Copy the full SHA 6cf63e9View commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b0ffab7 - Browse repository at this point
Copy the full SHA b0ffab7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.