fix: track socket before run middlewares #5158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -322,6 +322,9 @@ export class Namespace< | |||
| debug("adding socket to nsp %s", this.name); | |||
| const socket = await this._createSocket(client, auth); | |||
|
|
|||
| // track socket | |||
| this.sockets.set(socket.id, socket); | |||
There was a problem hiding this comment.
Hmm, I'm not sure about this change, since the sockets map currently contains only sockets that are actually connected (not in the process of connection).
|
Superseded by b04fa64. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
the socket is not tracked when run the middlewares
New behavior
track socket before run middlewares
Other information (e.g. related issues)
fix: #5139