add macro for old and new utf8-string #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add travis build add macro for old and new utf8-string
|
As much as I agree that a Travis build is nice, it's not a good idea, IHMO, to mix it up with this bug fix. The config file for Travis should go in a separate pull request. |
|
I guess, I wanted to prove it builds... |
|
It's just that mixing two unrelated patches into one PR feels a bit messy. Just 2 cents ... |
|
I have no issues with dropping |
|
I don't know whether it would help or not ... I am not an admin for this repository. |
|
I've taken over maintenance of this package and fixed utf8-string issue. The new repository location is http://github.com/bergmark/feed. I didn't manage to get travis to build that repo since it's a fork though, do you know if it's possible? |
|
Oh, I think I managed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add travis build -- easily can be seen it it works
bump version