Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImGui, GLFW] Fix crash when quitting #142

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jan 6, 2025

1- it was crashing in glfw/imgui if one quits using Escape key (due to erasing value in a map while iterating)
2- clean exit in imgui if one quits using the "exit" menu

Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I'll sleep better now.

@alxbilger alxbilger merged commit 9f494b9 into sofa-framework:master Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants