Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GitHub] Action to check labels #4079

Merged
merged 11 commits into from
Sep 3, 2023
Merged

[GitHub] Action to check labels #4079

merged 11 commits into from
Sep 3, 2023

Conversation

hugtalbot
Copy link
Contributor

Now, this action checks and make sure that sufficiently descriptive labels are set.
Among the 8 possible labels:

  • enhancement
  • deprecated
  • refactoring
  • pr: breaking
  • pr: clean
  • pr: fix
  • pr: new feature
  • pr: test

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress and removed enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Aug 5, 2023
@hugtalbot hugtalbot added enhancement About a possible enhancement and removed pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Aug 6, 2023
fredroy
fredroy requested changes Aug 6, 2023
View reviewed changes
.github/workflows/label-checker.yml Outdated Show resolved Hide resolved
@fredroy fredroy added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request and removed enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Aug 7, 2023
@hugtalbot hugtalbot requested a review from fredroy August 7, 2023 20:12
@hugtalbot hugtalbot requested a review from epernod August 21, 2023 14:09
epernod
epernod approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me.
Just for the logs, could you just put in a comment what should be the output of those messages if the PR fails to pass the tests.
just copy past the message or a screenshot of the result.

@hugtalbot
Copy link
Contributor Author

There you are @epernod : hugtalbot#10 (comment)

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 30, 2023
@epernod
Copy link
Contributor

epernod commented Aug 30, 2023

EJ1cXMfVAAAfvpW

@epernod epernod removed the pr: status ready Approved a pull-request, ready to be squashed label Aug 30, 2023
@hugtalbot hugtalbot added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Aug 31, 2023
@hugtalbot hugtalbot added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress and removed pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request labels Aug 31, 2023
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Aug 31, 2023
@hugtalbot hugtalbot removed the pr: status wip Development in the pull-request is still in progress label Aug 31, 2023
@hugtalbot
Copy link
Contributor Author

It seems fine now.
Only the message does not appear yet, I get as long as the PR is not merged.

@hugtalbot
Copy link
Contributor Author

@epernod @fredroy ready for you :)

epernod
epernod reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust your YAML skills 🤓

.github/workflows/label-checker.yml Outdated Show resolved Hide resolved
epernod
epernod reviewed Sep 1, 2023
View reviewed changes
.github/workflows/label-checker.yml Outdated Show resolved Hide resolved
.github/workflows/label-checker.yml Outdated Show resolved Hide resolved
@hugtalbot @epernod
Increase the delayed start of the action
fcb4f7d 
Co-authored-by: erik pernod <erik.pernod@gmail.com>
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 1, 2023
@epernod epernod merged commit 2b472b8 into sofa-framework:master Sep 3, 2023
3 of 4 checks passed
@hugtalbot hugtalbot added the pr: highlighted in next release Highlight this contribution in the notes of the upcoming release label Sep 14, 2023
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epernod epernod epernod approved these changes

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @epernod @fredroy