Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Topology] Rename Edge::pointBaryCoefs into Edge::getBarycentricCoordinates #4165

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[Topology] Rename Edge::pointBaryCoefs into Edge::getBarycentricCoordinates #4165

merged 1 commit into from
Sep 15, 2023

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Sep 13, 2023

Following code review in PR #4053 regarding Triangle version, propagate the same method name in Edge class

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 13, 2023
@epernod
Copy link
Contributor Author

epernod commented Sep 13, 2023

[ci-build][with-all-tests]

@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days and removed pr: status to review To notify reviewers to review this pull-request labels Sep 13, 2023
@epernod epernod changed the title [Topology] Rename Edge::pointBaryCoefs into pointBaryCoefs::getBarycentricCoordinates [Topology] Rename Edge::pointBaryCoefs into Edge::getBarycentricCoordinates Sep 13, 2023
@epernod epernod added the pr: status to review To notify reviewers to review this pull-request label Sep 13, 2023
@fredroy
Copy link
Contributor

fredroy commented Sep 13, 2023

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 15, 2023
@fredroy fredroy merged commit 649a41b into sofa-framework:master Sep 15, 2023
8 of 10 checks passed
@epernod epernod deleted the inf_2023_15_edgeBaryCoords branch September 15, 2023 06:43
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakpaul bakpaul bakpaul approved these changes

@fredroy fredroy fredroy approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v23.12
Development

Successfully merging this pull request may close these issues.
4 participants
@epernod @fredroy @bakpaul @hugtalbot