Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VolumetricRendering] Fix crashes in batch mode #4436

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jan 15, 2024

Those 2 components are purely based on OpenGL (opengl code in update visual and draw().
But unexpectedly, updateVisual() is called, even in batch mode
This PR simply skips the updateVisual() if the Visual params does not handle opengl (which is the case in batch)

Philosophical question: should we really updateVisual if there is no visual ?

root->execute<VisualUpdateVisitor>(params);


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jan 15, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Jan 15, 2024

[ci-build][with-all-tests]

@sofa-framework sofa-framework deleted a comment from sofabot Jan 16, 2024
@sofa-framework sofa-framework deleted a comment from sofabot Jan 16, 2024
@fredroy
Copy link
Contributor Author

fredroy commented Jan 16, 2024

[ci-build][with-all-tests][force-full-build]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 17, 2024
@hugtalbot hugtalbot merged commit c469ffc into sofa-framework:master Jan 17, 2024
17 checks passed
@hugtalbot hugtalbot deleted the batch_volumetricrendering branch January 17, 2024 10:32
bakpaul pushed a commit that referenced this pull request Feb 19, 2024
* workaround when using volumetricrendering in batch mode

* fix and clean computebbox
@bakpaul bakpaul added this to the v23.12 milestone Feb 20, 2024
@bakpaul bakpaul added the pr: backport done This PR has been backported into the release before its milestone. label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants