[VolumetricRendering] Fix crashes in batch mode #4436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those 2 components are purely based on OpenGL (opengl code in update visual and draw().
But unexpectedly, updateVisual() is called, even in batch mode
This PR simply skips the updateVisual() if the Visual params does not handle opengl (which is the case in batch)
Philosophical question: should we really updateVisual if there is no visual ?
sofa/Sofa/framework/Simulation/Core/src/sofa/simulation/Simulation.cpp
Line 274 in 26f65f1
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if