Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Lifecycle for v24.06 (1) #4532

Closed

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Feb 26, 2024

Now that the v23.12 is getting stable, this PR applies the lifecycle policy of SOFA for the v24.06 release.

Note that :

[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/265]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/139]
[ci-depends-on https://github.com/sofa-framework/CGALPlugin/pull/14]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Feb 26, 2024
@sofabot
Copy link
Collaborator

sofabot commented Feb 26, 2024

[ci-depends-on] detected during build #1.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor Author

I fixed the conflicts in #4533, let's use this PR to ease the code review
(less files to review)

@hugtalbot hugtalbot marked this pull request as draft February 27, 2024 09:21
@hugtalbot hugtalbot closed this Feb 28, 2024
@hugtalbot hugtalbot removed the pr: status to review To notify reviewers to review this pull-request label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants