[Core] Fix isSet flag when setting a link to a not-yet created data #5081
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
|
[ci-build][with-all-tests] |
|
Is this related to #4910? |
|
This should fix #4911 |
fredroy
force-pushed
the
fix_isset_data
branch
from
4377612
to
eeed371
Compare
fredroy
force-pushed
the
fix_isset_data
branch
2 times, most recently
from
2421208
to
cb5dbbe
Compare
bakpaul
reviewed
Nov 12, 2024
| {"printLog", "true"} | ||
| }); | ||
| auto* objdata4 = obj4->findData("printLog"); | ||
| ASSERT_TRUE(objdata4->isSet()); |
There was a problem hiding this comment.
Might be good to add a test with a wrong link ?
There was a problem hiding this comment.
Might be good to add a test with a wrong link ?
done.
Actually this remark leads to interesting consequences:
- there is no message/warning whatsoever if the link is wrong (i.e point to the non-existing data). This is understandable if setting a link a posteriori is a feature;
- more philosophical : should it be still isSet() if it is wrong ? but the link itself (no the pointed data) is set after all;
- the only way to know the link was wrong is to test if
getParent()is null... which would mean ideally that it should be tested every time...
There was a problem hiding this comment.
To me this is the result of a not very well defined/consistent behavior.
Actually I'm very unconvident on the general use of links that are searched "a posteriori" and wonder if we shouldn't remove and replace that by a different (and explicit mechanism).
fredroy
force-pushed
the
fix_isset_data
branch
from
4e86097
to
6f1897b
Compare
bakpaul
added
pr: status ready
fredroy
force-pushed
the
fix_isset_data
branch
from
6f1897b
to
01a7922
Compare
|
[ci-build][with-all-tests][force-full-build] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SimpleAPI and SofaPython3 (surely XML too),
if a data link is set to a data of a not-yet created BaseObject,
isSetis not true.In the newly created tests, the last one would be false without the fix in BaseData
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if