[runSofa,Helper] Changes screenshots and config directories location #5096
+72
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
reviewed
Nov 6, 2024
| { | ||
| CoTaskMemFree(path); | ||
| // else system calls are used | ||
| homeDir = getpwuid(getuid())->pw_dir; |
There was a problem hiding this comment.
getpwuid() and getuid() are POSIX system calls so it is not supported with Win32 API
alxbilger
added
the
pr: status to review
hugtalbot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directories
screenshotsandconfigare currently created in thebuilddirectory of SOFA. When installing the software on a machine, those can end up in a read-only directory.To avoid this problem, this PR changes:
On Linux:
screenshotslocation to:~/SOFAData/screenshots/configlocation to:~/.config/SOFA/config/On Windows:
screenshotslocation to:~/SOFAData/screenshots/configlocation to:~/AppData/Local/.config/SOFA/config/On MacOS:
screenshotslocation to:~/Library/Application Support/SOFAData/screenshots/configlocation to:~/Library/Application Support/.config/SOFA/config/These changes have only been tested on Linux. I'm not familiar with MacOS so I don't know what would be the best location.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if