Upgrade zipkin-repoter 3.4.0

[CrazyHZM]

Motivation:

sofaboot support 3.3.2 failed：sofastack/sofa-boot#1335

The reason is that sofa tracer is not compatible with zipkin repoter.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

Summary by CodeRabbit

• New Features

  • Upgraded the zipkin-reporter dependency to version 3.4.0, which may introduce new features and improvements to tracing capabilities.

• Bug Fixes

  • Adjusted imports in the Zipkin integration components to align with the latest library structure, potentially improving functionality and stability in tracing operations.

[coderabbitai]

Walkthrough

The recent updates to the sofa-tracer-zipkin-plugin included an important upgrade of the zipkin-reporter dependency from version 2.7.15 to 3.4.0, likely introducing new features and enhancements. Additionally, import statements in the Java files were updated to align with the restructuring of the library, changing how call handling and encoding are managed.

Changes

File Path	Change Summary
.../sofa-tracer-zipkin-plugin/pom.xml	Updated zipkin-reporter dependency version from 2.7.15 to 3.4.0.
.../sofa-tracer-zipkin-plugin/src/main/java/.../ZipkinRestTemplateSender.java .../ZipkinRestTemplateSenderTest.java	Changed imports for Call and Encoding from zipkin2 to zipkin2.reporter, reflecting a library restructure.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ZipkinRestTemplateSender
    participant ZipkinReporter

    Client->>ZipkinRestTemplateSender: SendTracingData()
    ZipkinRestTemplateSender->>ZipkinReporter: ReportData()
    ZipkinReporter-->>ZipkinRestTemplateSender: Acknowledge()
    ZipkinRestTemplateSender-->>Client: SendResponse()

Loading

Poem

Hopping through the code so bright,
New versions bring a joyful light.
From 2.7 to 3.4, we cheer,
With changes made, we have no fear!
In the land of tracing, we now play,
With happy hops, we code away! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0a5375a and 88eecf4.

Files selected for processing (3)

• sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/main/java/com/alipay/sofa/tracer/plugins/zipkin/sender/ZipkinRestTemplateSender.java (1 hunks)
• sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/test/java/com/alipay/sofa/tracer/plugins/zipkin/ZipkinRestTemplateSenderTest.java (1 hunks)

Additional comments not posted (5)

sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/test/java/com/alipay/sofa/tracer/plugins/zipkin/ZipkinRestTemplateSenderTest.java (2)

26-27: Imports updated correctly.

The import statements for Call and Encoding have been updated to reflect their new locations in the zipkin2.reporter package. Ensure that these changes are consistent with the new library structure.

---

Line range hint 34-71:
Test methods are correctly implemented.

The test methods are correctly using the updated imports and are testing the functionalities of ZipkinRestTemplateSender as expected.

sofa-tracer-plugins/sofa-tracer-zipkin-plugin/src/main/java/com/alipay/sofa/tracer/plugins/zipkin/sender/ZipkinRestTemplateSender.java (2)

25-26: Imports updated correctly.

The import statements for Call and Encoding have been updated to reflect their new locations in the zipkin2.reporter package. Ensure that these changes are consistent with the new library structure.

---

Line range hint 34-71:
Methods are correctly implemented.

The methods in ZipkinRestTemplateSender are correctly using the updated imports for Call and Encoding and are functioning as expected.

sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml (1)

32-32: Version update approved.

The version of the zipkin-reporter dependency has been updated from 2.7.15 to 3.4.0. Ensure that this update does not introduce any compatibility issues.

[yitongnb]

LGTM

[ZijieSong]

lgtm

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 88eecf4 and 3918cea.

Files selected for processing (1)

• sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml (1 hunks)

Additional comments not posted (1)

sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml (1)

32-32: Verify compatibility and functionality with zipkin-reporter version 3.4.0.

The upgrade to version 3.4.0 may introduce new features or changes that could affect compatibility with other dependencies or the functionality of the project. Ensure that the project builds successfully and passes all tests with this new version.

[CrazyHZM]

#534