Fix tracer runnable mdc clean

[ZijieSong]

Motivation:

SofaTracerRunnable do not clean up the MDC upon exit, causing an MDC leakage.

Modification:

Clean up MDC context upon exit

Summary by CodeRabbit

• New Features
  • Updated version across multiple projects to 3.1.7, indicating potential new features and improvements.
• Bug Fixes
  • Minor version updates may resolve existing issues and enhance overall performance.
• Chores
  • General dependency management improvements reflected in the version updates across various plugins and projects.

[coderabbitai]

Walkthrough

The updates across multiple pom.xml files reflect a minor version increment from 3.1.6 to 3.1.7 for the parent artifact tracer-all-parent. This change is consistent across various plugins and projects, indicating potential enhancements or bug fixes in the parent project. Additionally, a modification was made to the doFinally method in the FunctionalAsyncSupport.java file to improve logging functionality.

Changes

Files	Change Summary
pom.xml, sofa-tracer-plugins/.../pom.xml, tracer-all/pom.xml, tracer-core/pom.xml, tracer-extensions/pom.xml, tracer-sofa-boot-starter/pom.xml, tracer-test/core-test/pom.xml, tracer-test/log4j-test/pom.xml, tracer-test/log4j2-test/pom.xml, tracer-test/logback-test/pom.xml	Updated version from 3.1.6 to 3.1.7 for the parent artifact.
tracer-core/src/main/java/com/alipay/common/tracer/core/async/FunctionalAsyncSupport.java	Modified doFinally method to log stopped spans.

Sequence Diagram(s)

sequenceDiagram
    participant Thread
    participant TraceContext
    participant SpanExtensionFactory

    Thread->>TraceContext: Check current thread ID
    alt Thread ID matches
        TraceContext->>Thread: Continue processing
    else Thread ID does not match
        TraceContext->>Thread: Pop current span
        TraceContext->>SpanExtensionFactory: Log stopped span
    end

Loading

Poem

🐰 In the meadow where changes bloom,
A hop and a skip, dispelling gloom.
Versions rise like the sun so bright,
Enhancements dance in the morning light.
With logs that sing and spans that cheer,
A joyful update, let’s all revere! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5227295 and 2ff7d92.

Files selected for processing (27)

• pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-datasource-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-dubbo-2.6.x-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-dubbo-common-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-dubbo-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-flexible-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-httpclient-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-kafkamq-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-mongodb-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-okhttp-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-rabbitmq-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-redis-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-resttmplate-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-rocketmq-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-spring-cloud-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-springmessage-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-springmvc-plugin/pom.xml (1 hunks)
• sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml (1 hunks)
• tracer-all/pom.xml (1 hunks)
• tracer-core/pom.xml (1 hunks)
• tracer-core/src/main/java/com/alipay/common/tracer/core/async/FunctionalAsyncSupport.java (1 hunks)
• tracer-extensions/pom.xml (1 hunks)
• tracer-sofa-boot-starter/pom.xml (1 hunks)
• tracer-test/core-test/pom.xml (1 hunks)
• tracer-test/log4j-test/pom.xml (1 hunks)
• tracer-test/log4j2-test/pom.xml (1 hunks)
• tracer-test/logback-test/pom.xml (1 hunks)

Files skipped from review due to trivial changes (24)

• pom.xml
• sofa-tracer-plugins/sofa-tracer-datasource-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-dubbo-2.6.x-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-dubbo-common-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-dubbo-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-flexible-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-httpclient-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-kafkamq-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-mongodb-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-rabbitmq-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-redis-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-resttmplate-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-rocketmq-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-spring-cloud-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-springmessage-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-springmvc-plugin/pom.xml
• sofa-tracer-plugins/sofa-tracer-zipkin-plugin/pom.xml
• tracer-all/pom.xml
• tracer-core/pom.xml
• tracer-extensions/pom.xml
• tracer-sofa-boot-starter/pom.xml
• tracer-test/log4j-test/pom.xml
• tracer-test/log4j2-test/pom.xml
• tracer-test/logback-test/pom.xml

Additional comments not posted (3)

tracer-core/src/main/java/com/alipay/common/tracer/core/async/FunctionalAsyncSupport.java (1)

53-54: LGTM!

The addition of logging for the stopped span enhances traceability and debugging capabilities.

The code changes are approved.

sofa-tracer-plugins/sofa-tracer-okhttp-plugin/pom.xml (1)

8-8: Version update approved.

The version of the parent artifact has been incremented from 3.1.6 to 3.1.7, indicating potential enhancements or bug fixes in the parent project.

The code changes are approved.

tracer-test/core-test/pom.xml (1)

7-7: Version update approved.

The version of the parent artifact has been incremented from 3.1.6 to 3.1.7, indicating potential enhancements or bug fixes in the parent project.

The code changes are approved.