Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support transfer requestTemplate #539

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

lifaquan
Copy link
Contributor

@lifaquan lifaquan commented Sep 11, 2024

客户自定义扩展feign的场景,也能会从request中获取requestTemplate进一步处理,当前方式会导致requestTemplate丢失

Summary by CodeRabbit

  • New Features
    • Enhanced request handling by including a request template in the request construction process, allowing for more complex configurations and improved tracing capabilities.

Copy link

sofastack-cla bot commented Sep 11, 2024

Hi @lifaquan, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

Copy link

coderabbitai bot commented Sep 11, 2024

Walkthrough

The changes involve modifying the execute method in the SofaTracerFeignClient class by adding a new parameter, request.requestTemplate(), to the Request.create method call. This adjustment expands the parameters used to construct requests, which may facilitate more detailed request management.

Changes

Files Change Summary
sofa-tracer-plugins/sofa-tracer-spring-cloud-plugin/src/main/java/com/alipay/sofa/tracer/plugins/springcloud/instruments/feign/SofaTracerFeignClient.java Modified the execute method to include request.requestTemplate() in the Request.create method call.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SofaTracerFeignClient
    participant Request

    Client->>SofaTracerFeignClient: execute(Request, Options)
    SofaTracerFeignClient->>Request: create(method, url, headers, body, requestTemplate)
    SofaTracerFeignClient-->>Client: Response
Loading

🐰 In the meadow, a change did bloom,
A request template to lift the gloom.
With added detail, requests now flow,
In the world of tracing, watch it grow!
Hops of joy, for code so bright,
A rabbit's cheer for the coding light! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b86de44 and 11a9f0a.

Files selected for processing (1)
  • sofa-tracer-plugins/sofa-tracer-spring-cloud-plugin/src/main/java/com/alipay/sofa/tracer/plugins/springcloud/instruments/feign/SofaTracerFeignClient.java (1 hunks)
Additional comments not posted (1)
sofa-tracer-plugins/sofa-tracer-spring-cloud-plugin/src/main/java/com/alipay/sofa/tracer/plugins/springcloud/instruments/feign/SofaTracerFeignClient.java (1)

68-68: Looks good! This change supports user-defined extensions by preserving the requestTemplate.

The addition of request.requestTemplate() as a parameter to the Request.create method ensures that the requestTemplate is accessible for further processing by users who are customizing their Feign clients.

This aligns with the PR objective of supporting user-defined extensions of Feign and addresses the issue of losing the requestTemplate in the existing implementation.

The change is targeted and does not introduce any apparent issues or side-effects.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ZijieSong ZijieSong merged commit 27ecf89 into sofastack:master Sep 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants