[feat] 이벤트 삭제 기능 구현(#131) #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaxsior
commented
Aug 22, 2024
| Instant endTime = metadata.getEndTime(); | ||
| Instant now = Instant.now(); | ||
|
|
||
| if(startTime.isBefore(now)) { |
There was a problem hiding this comment.
팀원들과 논의한 대로 이벤트가 진행 중이거나 완료된 경우에는 임의로 삭제할 수 없게 만들었습니다.
There was a problem hiding this comment.
논의 내용 신속하게 반영해주셔서 감사드립니다.
blaxsior
commented
Aug 22, 2024
| @@ -9,58 +9,60 @@ | |||
| @Getter | |||
| public enum ErrorCode { | |||
| // 400 Bad Request | |||
| BAD_REQUEST(HttpStatus.BAD_REQUEST, false, "잘못된 요청입니다."), | |||
There was a problem hiding this comment.
success 필드는 초기에 성공 / 실패의 경우 모두 사용하려고 했던 당시의 잔재로, 현재는 항상 실패하는 경우에 대한 에러 메시지만 담고 있으므로 필요하지 않습니다. 따라서 필요 없는 success 코드를 제거합니다.
There was a problem hiding this comment.
구현에만 집중한 나머지 커스텀 응답객체를 사용하지 않기 때문에 success 필드의 존재를 잊고 있었네요.
2 tasks
win-luck
approved these changes
Aug 22, 2024
| @@ -9,58 +9,60 @@ | |||
| @Getter | |||
| public enum ErrorCode { | |||
| // 400 Bad Request | |||
| BAD_REQUEST(HttpStatus.BAD_REQUEST, false, "잘못된 요청입니다."), | |||
There was a problem hiding this comment.
구현에만 집중한 나머지 커스텀 응답객체를 사용하지 않기 때문에 success 필드의 존재를 잊고 있었네요.
| Instant endTime = metadata.getEndTime(); | ||
| Instant now = Instant.now(); | ||
|
|
||
| if(startTime.isBefore(now)) { |
There was a problem hiding this comment.
논의 내용 신속하게 반영해주셔서 감사드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용
이벤트 삭제 기능을 추가했습니다. 정책은 다음과 같습니다.