Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use node-fetch #386

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

timor-raiman
Copy link
Contributor

closes #206

@@ -159,16 +158,17 @@ export const upload = async (
console.log(`⬆️ Uploading ${name}...`);
const endpoint = new URL(url);
endpoint.searchParams.append("name", name);
const resp = await fetch(endpoint, {
const resp = await github.request({
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. nice

@softprops softprops merged commit 1468521 into softprops:master Mar 8, 2024
1 check passed
@softprops
Copy link
Owner

this should be available in the new v2 tag

cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/renovate-bot Mar 9, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[softprops/action-gh-release](https://togithub.com/softprops/action-gh-release)
| action | patch | `v2.0.0` -> `v2.0.1` |

---

### Release Notes

<details>
<summary>softprops/action-gh-release
(softprops/action-gh-release)</summary>

###
[`v2.0.1`](https://togithub.com/softprops/action-gh-release/releases/tag/v2.0.1)

[Compare
Source](https://togithub.com/softprops/action-gh-release/compare/v2.0.0...v2.0.1)

- Add support for make_latest property
[https://github.com/softprops/action-gh-release/pull/304](https://togithub.com/softprops/action-gh-release/pull/304)
via [@&#8203;samueljseay](https://togithub.com/samueljseay)
- Fail run if files setting contains invalid patterns
[https://github.com/softprops/action-gh-release/pull/384](https://togithub.com/softprops/action-gh-release/pull/384)
via [@&#8203;rpdelaney](https://togithub.com/rpdelaney)
- Add support for proxy env variables (don't use node-fetch)
[https://github.com/softprops/action-gh-release/pull/386](https://togithub.com/softprops/action-gh-release/pull/386)/
via [@&#8203;timor-raiman](https://togithub.com/timor-raiman)
- Suppress confusing warning when input_files is empty
[https://github.com/softprops/action-gh-release/pull/389](https://togithub.com/softprops/action-gh-release/pull/389)
via [@&#8203;Drowze](https://togithub.com/Drowze)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proxy
2 participants