chore(gradle): list logback dependency individually

software-challenge · Sep 4, 2023 · 1ed177c · 1ed177c
1 parent 3b1331b
commit 1ed177c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/gradle/build.gradle.kts b/gradle/build.gradle.kts
@@ -240,8 +240,6 @@ subprojects {
 
     dependencies {
         testImplementation(project(":sdk", "testConfig"))
-        if(name in listOf("server", "player", "test-client"))
-            implementation("ch.qos.logback", "logback-classic", "1.3.11") // Update to 1.4 with JDK upgrade
     }
 
     tasks {

diff --git a/helpers/test-client/build.gradle.kts b/helpers/test-client/build.gradle.kts
@@ -16,6 +16,7 @@ application {
 dependencies {
     implementation(project(":sdk"))
     implementation(project(":server")) // Only to access defaults of sc.server.Configuration
+    implementation("ch.qos.logback", "logback-classic", "1.3.11") // Update to 1.4 with JDK upgrade
     runtimeOnly(project(":plugin"))
 }
 

diff --git a/player/build.gradle.kts b/player/build.gradle.kts
@@ -1,5 +1,5 @@
-import java.time.Duration
 import org.gradle.internal.os.OperatingSystem
+import java.time.Duration
 
 plugins {
     application
@@ -24,6 +24,7 @@ application {
 dependencies {
     implementation(project(":plugin"))
     implementation(kotlin("script-runtime"))
+    implementation("ch.qos.logback", "logback-classic", "1.3.11") // Update to 1.4 with JDK upgrade
 }
 
 tasks {

diff --git a/server/build.gradle.kts b/server/build.gradle.kts
@@ -13,8 +13,9 @@ application {
 
 dependencies {
     api(project(":sdk"))
-    runtimeOnly(project(":plugin"))
+    implementation("ch.qos.logback", "logback-classic", "1.3.11") // Update to 1.4 with JDK upgrade
 
+    runtimeOnly(project(":plugin"))
     testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine") // legacy java tests
 }