Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 add a repeat macro to wigsill #10

Merged
merged 10 commits into from
Jul 11, 2024
Merged

#5 add a repeat macro to wigsill #10

merged 10 commits into from
Jul 11, 2024

Conversation

reczkok
Copy link
Collaborator

@reczkok reczkok commented Jul 8, 2024

closes #5

@reczkok reczkok requested a review from iwoplaza July 8, 2024 13:19
@reczkok reczkok changed the title Feat/repeat #5 add a repeat macro to wigsill Jul 8, 2024
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the tiny nitpick, and further suggestions I posted in #5, it looks great!
Awesome work ( ◦°^°◦) 💚

packages/wigsill/tests/macro.test.ts Outdated Show resolved Hide resolved
@reczkok
Copy link
Collaborator Author

reczkok commented Jul 9, 2024

I made the changes as suggested - I will re-request review. Let me know if that is what you meant (˶ᵔ ᵕ ᵔ˶)

@reczkok reczkok requested a review from iwoplaza July 9, 2024 19:42
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🐸 💚

@reczkok reczkok merged commit b4557cc into main Jul 11, 2024
9 checks passed
@reczkok reczkok deleted the feat/repeat branch July 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a repeat macro that executes a statement N times.
2 participants