Synchronized diagnostics worker threads #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcticae
requested review from
mkaput and
Draggu
and removed request for
a team
Arcticae
force-pushed
the
feature/joined-diagnostics-threads
branch
from
14a3398 to
05eae23
Compare
mkaput
requested changes
Jan 16, 2025
piotmag769
approved these changes
Jan 16, 2025
Draggu
requested changes
Jan 16, 2025
piotmag769
requested changes
Jan 16, 2025
Draggu
reviewed
Jan 16, 2025
Draggu
reviewed
Jan 16, 2025
Draggu
reviewed
Jan 17, 2025
mkaput
requested changes
Jan 17, 2025
piotmag769
approved these changes
Jan 17, 2025
Draggu
approved these changes
Jan 19, 2025
Arcticae
force-pushed
the
feature/joined-diagnostics-threads
branch
from
62ad275 to
a9bd5c8
Compare
Arcticae
force-pushed
the
feature/joined-diagnostics-threads
branch
from
a9bd5c8 to
b1a0a44
Compare
mkaput
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack ⬆️ : #44
In order to achieve more robust tracking of diagnostics progress, we need to make those threads converge.
That means two different generations' threads now don't run in parallel, and modify state (in turn making the progress tracking very difficult).