Skip to content

Introduce per-crate plugin model #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Introduce per-crate plugin model #210

merged 1 commit into from
Feb 21, 2025

Conversation

integraledelebesgue
Copy link
Member

@integraledelebesgue integraledelebesgue commented Jan 21, 2025 •
edited
Loading

Changes

  • Compiler plugins and procedural macros are handled separately for each crate
  • Procedural macro support is now on by default

@integraledelebesgue integraledelebesgue requested a review from a team as a code owner January 21, 2025 17:50
@integraledelebesgue integraledelebesgue requested review from mkaput and piotmag769 and removed request for a team January 21, 2025 17:50
This was referenced Jan 21, 2025
Merged
Merged
Merged
@integraledelebesgue integraledelebesgue marked this pull request as draft January 21, 2025 17:50
@integraledelebesgue integraledelebesgue marked this pull request as ready for review January 22, 2025 11:05
@integraledelebesgue integraledelebesgue marked this pull request as draft January 22, 2025 11:45
@integraledelebesgue integraledelebesgue force-pushed the spr/main/22479572 branch 3 times, most recently from 5492a42 to f9e76de Compare January 22, 2025 17:15
@integraledelebesgue integraledelebesgue force-pushed the spr/main/22479572 branch 2 times, most recently from 0ae9e18 to 7ca4502 Compare January 23, 2025 12:41
@integraledelebesgue integraledelebesgue force-pushed the spr/main/988401af branch 2 times, most recently from ff0fc4d to 8364856 Compare January 23, 2025 12:46
@integraledelebesgue integraledelebesgue force-pushed the spr/main/22479572 branch 2 times, most recently from 25bdd40 to 1ee8c6f Compare January 23, 2025 12:57
@integraledelebesgue integraledelebesgue force-pushed the spr/main/22479572 branch 2 times, most recently from 200df0a to a10d08a Compare February 3, 2025 14:18
@integraledelebesgue integraledelebesgue marked this pull request as ready for review February 10, 2025 09:37
@integraledelebesgue integraledelebesgue mentioned this pull request Feb 20, 2025
Merged
integraledelebesgue
integraledelebesgue commented Feb 20, 2025
View reviewed changes
integraledelebesgue
integraledelebesgue commented Feb 20, 2025
View reviewed changes
mkaput
mkaput requested changes Feb 21, 2025
View reviewed changes
Base automatically changed from spr/main/988401af to main February 21, 2025 14:27
@integraledelebesgue
Handle plugins per each crate
02a1787 
commit-id:22479572
@integraledelebesgue integraledelebesgue changed the title Handle plugins per each crate Introduce per-crate plugin model Feb 21, 2025
@integraledelebesgue integraledelebesgue added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 4e70b9c Feb 21, 2025
22 checks passed
@integraledelebesgue integraledelebesgue deleted the spr/main/22479572 branch February 21, 2025 14:51
Arcticae
Arcticae reviewed Feb 21, 2025
View reviewed changes
tests/e2e/scarb/ignore_warnings_from_non_path_deps.rs
@@ -47,8 +47,12 @@ fn test_ignore_warnings_from_non_path_deps() {
"src/lib.cairo" => cairo,
}
client_capabilities = caps;
// TODO (#339) - remove `enableProcMacros` from here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do in #339

This was linked to issues Feb 21, 2025
Allow setting separate plugin suites per crate #70
Closed
LS: Support builtin plugins per-crate #76
Closed
Enable proc macros by default #141
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arcticae Arcticae Arcticae left review comments

@piotmag769 piotmag769 piotmag769 approved these changes

@Draggu Draggu Draggu approved these changes

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable proc macros by default LS: Support builtin plugins per-crate Allow setting separate plugin suites per crate
5 participants
@integraledelebesgue @mkaput @Arcticae @piotmag769 @Draggu