Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten duration of replay rewind animation #743

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

p-malecki
Copy link
Contributor

This PR shortens duration of rewind animation to improve the usability of the rewind feature. The longer version of the animation is played only the first time a user accesses this feature. We track this by storing a variable called "wasReplayRewindIntroduced" in localStorage.

Testing:

Inspect the wasReplayRewindIntroduced state using the Storage Inspector in WebView Developer Tools. Initially, before the 'introduction' of the rewind feature, this variable should not exist. After the feature is first used, it should be created with the value "true". Ensure that the duration of the first replay is 1 second longer than every subsequent replay.

Before After
Screen.Recording.2024-11-19.at.13.29.28.mov
Screen.Recording.2024-11-19.at.13.30.16.mov

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 8:22pm

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think there's a lot of value in adding extra persistent state just to show longer animation. We should just decide on the length (1.5sec should be ok I believe) and use it at all times (or remove this animation entirely)

@p-malecki
Copy link
Contributor Author

Don't think there's a lot of value in adding extra persistent state just to show longer animation. We should just decide on the length (1.5sec should be ok I believe) and use it at all times (or remove this animation entirely)

The previous animation duration was 1.6 sec, so reducing it to 1.5 seconds wouldn't make a significant difference. We agreed experimentally that 0.6 seconds is the best duration for usability, but that may be too fast for the first impression of rewind animation.
If we decide to drop the idea of a longer first animation, I think we should settling on 0.6 sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants