feat(Android): make fitToContents sheet height react to dynamic content
#2893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh yeah, highly appreciated. Together with the keyboard support 👨🍳 💋 |
|
My old pile of hacks stopped working with SDK 53, I hope we can merge this PR and release a new version soon-ish, that would be a-mazing! |
|
@kkafar will you review this PR? this is highly needed for our bottom-sheet solution. thank you |
|
Hello and thank you very much for your library :) Do you think you could merge this PR in the near future? |
Contributor
|
the work is continued in this PR: #3484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Changes
WIP
Screenshots / GIFs
android_form_sheet_fit_to_contents_poc.mp4
Test code and steps to reproduce
WIP
Checklist