chore(Stack): rename maxLifecycleState to activityMode
#3505
+83
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following naming from RFC-0591. This commit also does necessary cleanup of no longer used types such as `StackScreenLifecycleState`. RNSConversion-Stack is introduced with a `convert` function template, which can be possibly later reused for other components as well.
kkafar
requested review from
kligarski,
kmichalikk and
t0maboro
and removed request for
t0maboro
kkafar
commented
Jan 5, 2026
Member
Author
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
I'll proceed here, because the changes apply to gamma (not stable) component & I've got too many changes stacked, which leads to hell in PR management.
Please do a review anyway, I'll act on it in follow up PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
maxLifecycleStatetoactivityModeFollowing naming from RFC-0591.
This commit also does necessary cleanup of no longer used types such as
StackScreenLifecycleState.RNSConversion-Stack is introduced with a
convertfunction template,which can be possibly later reused for other components as well.