Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying custom Scarb.lock path #27

Merged
merged 12 commits into from
Oct 10, 2024
Merged

Support specifying custom Scarb.lock path #27

merged 12 commits into from
Oct 10, 2024

Conversation

DelevoXDG
Copy link
Contributor

@DelevoXDG DelevoXDG commented Oct 9, 2024 •
edited
Loading

  • Allow specifying path to Scarb.lock via optional scarb-lock argument
  • If not specified, default to Scarb.lock in cwd for consistency with toolVersionsPath
  • Fix caching test steps

Closes #25

@DelevoXDG DelevoXDG force-pushed the zdobnikau/25-custom-lockfile-path branch 2 times, most recently from d44762a to 6791187 Compare October 9, 2024 15:42
@DelevoXDG DelevoXDG force-pushed the zdobnikau/25-custom-lockfile-path branch from 6791187 to 803c44c Compare October 9, 2024 15:45
@DelevoXDG DelevoXDG force-pushed the zdobnikau/25-custom-lockfile-path branch from 57bbad5 to 11d9eac Compare October 9, 2024 16:24
@DelevoXDG
Copy link
Contributor Author

DelevoXDG commented Oct 9, 2024 •
edited
Loading

Test run: https://github.com/software-mansion/setup-scarb/actions/runs/11259430092/job/31308372155#step:16:16

@DelevoXDG DelevoXDG force-pushed the zdobnikau/25-custom-lockfile-path branch from 790dbe6 to 3566593 Compare October 9, 2024 16:47
@DelevoXDG DelevoXDG marked this pull request as ready for review October 9, 2024 16:50
@DelevoXDG DelevoXDG requested a review from mkaput as a code owner October 9, 2024 16:50
@DelevoXDG DelevoXDG requested a review from maciektr October 9, 2024 16:50
@DelevoXDG DelevoXDG added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit f4e6c94 Oct 10, 2024
5 checks passed
@DelevoXDG DelevoXDG deleted the zdobnikau/25-custom-lockfile-path branch October 10, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support caching in projects with different lockfiles location
3 participants
@DelevoXDG @mkaput @maciektr