Skip to content

Update code quality check jar#540

Merged
frozenfrank merged 1 commit intomainfrom
update-quality-checker-jar
Feb 12, 2025
Merged

Update code quality check jar#540
frozenfrank merged 1 commit intomainfrom
update-quality-checker-jar

Conversation

@19mdavenport
Copy link
Contributor

Overview

Updates the quality checker jar with softwareconstruction240/checkstyle#6

Details

  • Removes some duplicated reports of duplicate code

Testing

  • Added/updated unit tests (in other repository)
  • Tested edge cases
  • Manual testing (if needed)

Copy link
Contributor

@frozenfrank frozenfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was already approved in softwareconstruction240/checkstyle#6

@frozenfrank
Copy link
Contributor

I wonder if there is a way we can streamline the approval process for PRs like this... Probably not.

@frozenfrank
Copy link
Contributor

Actually, I can imagine a way... There may be a way to get fancy with the branch protection rules to exclude things like this... It might be worth looking in to later.

@frozenfrank frozenfrank merged commit e93a211 into main Feb 12, 2025
3 checks passed
@frozenfrank frozenfrank deleted the update-quality-checker-jar branch February 12, 2025 06:05
@frozenfrank
Copy link
Contributor

I merged it immediately so we don't have to update from main again later. This has already been approved and merged elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants