Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a hotfix for the error message that says "You are not in the queue" even though users are in fact in the queue.
The root of the problem was the change in my last PR of the cookie to
HttpOnly. These queue updates rely on websocket messages that were intiated by sending the user's auth token. In response, they got grading updates. Now that the token is inaccessable, the backend can't get the user.This was fixed by reading the cookie instead of the websocket message.
Details
Before
After
Testing
Future Work
There's a good chance this will cause an error for Test Student, but I'd rather everyone else have the correct display. There's probably also some code cleanup that needs to happen, but I will address this later.