bump deps and fix java annotations #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really know anything about the mima stuff but imagine that the failure there is inevitable and ignorable? I made this because I saw the ticket about V2 and thought it a good opportunity to make the extra API changes... |
|
@hughsimpson thanks! yeah there's a couple of other changes as well waiting for porting, so that at some point we can get v2 up to speed and ship ;) |
|
since it's v2 mima fails (as there are other bin-incompat changes), so that's expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'forward-porting' #559
Since v2 is presumably intended to encapsulate breaking changes, I figured 'hey, let's make all these
AnydeclsAnnotationdecls since that's nicer'.I also bumped some deps so that I could build locally on Java 21