feat(001-baseline-sdd-spec): complete baseline SDD specification — all 13 phases

[softwaresalt]

Summary

Implements the complete baseline Software Design Document (SDD) specification for csv-managed v1.0.x across 13 phases, validating all 59 functional requirements (FR-001 through FR-059) against the existing codebase.

What Changed

Source Code (9 files modified)

File	Changes
src/data.rs	Replace panic! in Value::Ord with deterministic variant_index() fallback for heterogeneous comparisons
src/io_utils.rs	Remove sole unsafe block — use safe std::str::from_utf8 instead of from_utf8_unchecked
src/schema_cmd.rs	Replace 3 .expect() calls with .context()/? propagation on user-reachable paths
src/schema.rs	Convert value_column_type to return Result<ColumnType>; replace 4 .expect() calls with ? propagation; add failure-path test for Schema::load
src/stats.rs	Replace partial_cmp().unwrap() in median sort with f64::total_cmp()
src/frequency.rs	Replace 2 .expect() calls with .context()/?
src/index.rs	Add Rustdoc to all 22 public items; add 2 failure-path unit tests
src/filter.rs	Add Rustdoc to all 4 public items; add 3 failure-path unit tests
src/verify.rs, src/append.rs, src/columns.rs, src/install.rs, src/join.rs	Add module-level //! Rustdoc

Tests (1 new file, 6 new unit tests across modules)

• tests/edge_cases.rs — 14 integration tests covering: empty CSV, header-only CSV, unknown filter column, malformed derive expression, empty stdin, decimal precision overflow, column rename transparency, multiple filter AND semantics, sort without index fallback
• 6 failure-path unit tests in filter.rs, index.rs, schema.rs

Specification & Documentation

• specs/001-baseline-sdd-spec/ — complete spec, plan, tasks (all 144 tasks marked complete), data model, contracts, quickstart, research, checklists
• docs/ — ADRs, CLI help, operation guides, schema examples, pipeline documentation
• .copilot-tracking/memory/ — session memory files for all 13 phases

Quality Gates

Gate	Result
cargo test --all	✅ 229 passed, 0 failed, 1 ignored
cargo clippy --all-targets --all-features -- -D warnings	✅ Zero warnings
cargo doc --no-deps	✅ Builds clean
cargo fmt --check	✅ Clean
Quickstart examples validation	✅ All documented workflows verified
FR cross-reference (59 FRs)	✅ 100% coverage confirmed

Constitution Compliance

• ✅ No unsafe blocks (removed the sole instance in io_utils.rs)
• ✅ No unwrap()/expect() in library code (all 11 instances remediated)
• ✅ All public items have /// Rustdoc comments
• ✅ anyhow::Result with .with_context() throughout
• ✅ Streaming-first architecture — no full-file buffering in row processing
• ✅ Every public parser has at least one failure-path test

Code Review Findings Resolved

ID	Category	Severity	Description	Resolution
RI-01	Correctness	CRITICAL	Value::Ord panics on heterogeneous variants	Replaced with deterministic variant_index() fallback
RI-02	Security	HIGH	unsafe { from_utf8_unchecked } in io_utils	Replaced with safe from_utf8 + error propagation
RI-03	Convention	HIGH	3 .expect() calls on user-triggered paths	Converted to .context()/?
RI-04	Convention	MEDIUM	partial_cmp().unwrap() in median sort	Replaced with total_cmp()
RI-05	Convention	MEDIUM	2 .expect() calls in frequency.rs	Converted to .context()/?
RI-06	Convention	MEDIUM	4 .expect() calls in schema.rs	Refactored value_column_type to Result; all converted to ?
RI-07	Convention	LOW	Missing module docs (3 files)	Added //! module-level Rustdoc

Deferred Items (out of scope)

• schema.rs at 3,195 lines — split into submodules (architectural refactor)
• process.rs execute() at 210 lines — extract phases (refactor)
• Streaming median algorithm — currently uses Vec<f64> accumulator
• println! in verify.rs/schema_cmd.rs — near CLI output boundary, acceptable

[Copilot]

Pull request overview

This pull request implements the complete baseline Software Design Document (SDD) specification for csv-managed v1.0.2, documenting the existing codebase across 13 phases and validating all 59 functional requirements.

Changes:

• Documented the existing csv-managed v1.0.2 baseline implementation as a formal SDD specification
• Added comprehensive specification artifacts including plan, research, data model, contracts, and quickstart documentation
• Added 20 new integration tests and 6 unit tests covering edge cases and acceptance scenarios

Reviewed changes

Copilot reviewed 63 out of 64 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
specs/001-baseline-sdd-spec/*	Complete baseline SDD specification with 13 phases, 144 tasks, and 59 FR coverage
tests/edge_cases.rs	New edge case test suite with 14 integration tests
tests/cli.rs	Added 10 integration tests for append, install, and observability
tests/schema.rs	Added 3 integration tests for schema probe and verify
tests/process.rs	Added 3 integration tests for derived columns and expressions
tests/stats.rs	Added 2 integration tests for decimal/currency precision
tests/stdin_pipeline.rs	Added 1 integration test for preview mode in pipelines
src/data.rs	Added 6 unit tests for boolean, date, and currency parsing
src/index.rs	Added 2 unit tests for failure paths
src/filter.rs	Added 3 unit tests for filter parsing
src/schema.rs	Added 1 unit test for schema load failure
.copilot-tracking/*	Session memory files and checkpoints from all 13 phases
.github/agents/*	Added 5 agent definitions for workflow automation
.github/skills/*	Added 2 skill definitions for workflow automation
docs/adrs/*	Added 2 architecture decision records
.hve-tracking.json	HVE core tracking configuration
.vscode/mcp.json	MCP server configuration
lib/hve-core	Submodule update to d3bdd7aad

[Copilot]

Pull request overview

Copilot reviewed 63 out of 64 changed files in this pull request and generated no new comments.