Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
sokil committed Jan 23, 2021
1 parent 92464c6 commit 8f671c5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
vendor
composer.lock
tests/.phpunit.result.cache
2 changes: 1 addition & 1 deletion tests/AbstractTestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ protected function assertVastDocumentSameWithXmlFixture($expectedXmlFixturePath,
{
$this->assertXmlStringEqualsXmlFile(
$this->getFullXMLFixturePath($expectedXmlFixturePath),
$actualXmlDomDocument->toDomDocument()
(string)$actualXmlDomDocument
);
}
}
7 changes: 3 additions & 4 deletions tests/DocumentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,10 @@ public function testCreateAdSectionWithDelivery()

/**
* Test for creating media file with invalid delivery
* @expectedException \Exception
* @expectedExceptionMessage Wrong delivery specified
*/
public function testCreateAdSectionWithInvalidDelivery()
{
$this->expectExceptionMessage('Wrong delivery specified');
$factory = new Factory();
$document = $factory->create('2.0');

Expand Down Expand Up @@ -453,8 +452,8 @@ public function testToString()
$factory = new Factory();
$document = $factory->create('2.0');

$this->assertContains('<?xml version="1.0" encoding="UTF-8"?>', (string)$document);
$this->assertContains('<VAST version="2.0"/>', (string)$document);
$this->assertStringContainsString('<?xml version="1.0" encoding="UTF-8"?>', (string)$document);
$this->assertStringContainsString('<VAST version="2.0"/>', (string)$document);
}

/**
Expand Down

0 comments on commit 8f671c5

Please sign in to comment.