feat(signer): sync solana-keychain to 1.0.1 and add new signer adapters#416
feat(signer): sync solana-keychain to 1.0.1 and add new signer adapters#416
Conversation
- Bump solana-keychain dependency from 0.2.1 to 1.0.1 - Fix breaking API changes: from_kms → from_aws_kms, add http_client_config: None to from_vault, from_privy, from_turnkey, and FireblocksSignerConfig initializer - Add GcpKms, Para, Cdp, Dfns, and Crossmint signer configs, enum variants, build functions, and validate functions
📊 TypeScript Coverage ReportCoverage: 33.9% View detailed reportCoverage artifacts have been uploaded to this workflow run. |
Greptile SummaryThis PR bumps Confidence Score: 5/5Safe to merge; the single finding is a P2 validation gap that still produces an error at runtime, not a silent data-loss or security issue. All remaining findings are P2: the signer_secret_env omission in validate_crossmint_config delays an env-var error from config load to signer creation, but the error is still surfaced and the happy path is unaffected. No P0/P1 issues were found. crates/lib/src/signer/config.rs — specifically validate_crossmint_config Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[signers.toml] -->|TOML parse| B[SignerPoolConfig]
B --> C[validate_signer_config]
C --> D{SignerTypeConfig}
D -->|Memory| E[build_memory_signer]
D -->|Turnkey| F[build_turnkey_signer]
D -->|Privy| G[build_privy_signer]
D -->|Vault| H[build_vault_signer]
D -->|AwsKms| I[build_aws_kms_signer]
D -->|Fireblocks| J[build_fireblocks_signer]
D -->|GcpKms NEW| K[build_gcp_kms_signer]
D -->|Para NEW| L[build_para_signer]
D -->|Cdp NEW| M[build_cdp_signer]
D -->|Dfns NEW| N[build_dfns_signer]
D -->|Crossmint NEW| O[build_crossmint_signer]
E & F & H --> P[solana_keychain::Signer sync]
G & I & J & K & L & N & O --> Q[solana_keychain::Signer async]
M --> P
P & Q --> R[KoraSigner pool]
Reviews (1): Last reviewed commit: "feat(signer): sync solana-keychain to 1...." | Re-trigger Greptile |
Summary
solana-keychainfrom0.2.1to1.0.1from_kms→from_aws_kms; addhttp_client_config: Nonetofrom_vault,from_privy,from_turnkey, andFireblocksSignerConfiginitializerGcpKms,Para,Cdp,Dfns,Crossmint— each with config struct,SignerTypeConfigvariant, build function, and validate functionTest Plan
cargo check -p kora-libpassescargo clippy -p kora-libpasses📊 Unit Test Coverage
Unit Test Coverage: 83.3%
View Detailed Coverage Report