Replace subscriptionConfigurationHash with RpcRequest in RpcSubscriptionsPlan

[lorisleiva]

This PR replaces the subscriptionConfigurationHash attribute from the RpcSubscriptionsPlan type by a request attribute of type RpcRequest representing the user intent to request to an RPC Subscription.

The main issue with having a subscriptionConfigurationHash attribute defined in the interfaces of RPC Subscriptions is that it is mainly useful to create a coalescer transport decorator and, therefore, is application-specific. By providing the full RpcRequest instead, transports can decide to use this information however they see fit. For instance, a coalescer transport may hash all of the request data whereas a sharding transport may only use the method name of the request. Notice how the @solana/fast-stable-stringify package has now moved from the API package to the package that defines the coalescer transport.

Additionally, this PR replaces the getSubscriptionConfigurationHash function of the RpcSubscriptionsApiConfig type by an RpcRequestTransformer. That way, the createRpcSubscriptionsApi function can prepare the raw request (from the proxy), transform it using the provided request transformer and pass the transformed request into the plan executor.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4eab8d5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[lorisleiva]

• Replace subscriptionConfigurationHash with RpcRequest in RpcSubscriptionsPlan #3406 👈
• Add changeset for using RpcRequest and RpcResponse in RPC Subscriptions #3407
• Use RpcRequest in PlanExecutor configs #3405
• Use RpcResponseTransformer in PubSubSubscriptionPlan #3404
• Use RpcRequest in PubSubSubscriptionPlan #3403
• Use RpcRequest in createRpcMessage helper #3394
• Move RpcRequest and RpcResponse types to rpc-spec-types #3393
• Remove unused RpcSubscriptionsRequest type #3391
• Temporarily disable Node 23 CI tests #3395
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite

[mcintyre94]

Awesome, this looks way cleaner!

[steveluscher]

[lorisleiva]

Merge activity

• Oct 23, 4:43 AM EDT: A user started a stack merge that includes this pull request via Graphite.
• Oct 23, 5:09 AM EDT: Graphite rebased this pull request as part of a merge.
• Oct 23, 5:10 AM EDT: A user merged this pull request with Graphite.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/jest-runner-eslint@2.2.1	Transitive: environment, filesystem, shell, unsafe	+19	363 kB	simenb
npm/jest-runner-prettier@1.0.0	Transitive: environment, eval, filesystem, network, shell, unsafe	+215	26.2 MB	keplersj
npm/jest-watch-master@1.0.0	Transitive: environment	+27	1.94 MB	rickhanlonii
npm/jest-watch-select-projects@2.0.0	None	+10	323 kB	simenb
npm/jest-watch-typeahead@2.2.2	Transitive: environment, filesystem, unsafe	+40	843 kB	simenb
npm/jest-websocket-mock@2.5.0	None	+9	340 kB	romgain
npm/jest@30.0.0-alpha.6	Transitive: environment, eval, filesystem, network, shell, unsafe	+233	20.5 MB	simenb
npm/jscodeshift@17.0.0	Transitive: environment, filesystem, unsafe	+102	16.1 MB	daniel15
npm/json-stable-stringify@1.1.1	Transitive: eval	+9	208 kB	ljharb
npm/tinybench@2.9.0	None	0	62.9 kB	aslemammad

🚮 Removed packages: npm/swr@2.2.5, npm/typescript@5.5.4, npm/yoctocolors@2.1.1

View full report↗︎

[github-actions]

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.