Add undefined check.

solana-mobile · Jul 26, 2024 · e1eebce · e1eebce
1 parent 9be029c
commit e1eebce
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/packages/cli/src/config/PublishDetails.ts b/packages/cli/src/config/PublishDetails.ts
@@ -181,16 +181,18 @@ export const loadPublishDetailsWithChecks = async (
   }
 
   const alpha_testers = config.solana_mobile_dapp_publisher_portal.alpha_testers;
-  for (const wallet of alpha_testers) {
-    try {
-      void new PublicKey(wallet.address);
-    } catch (e: unknown) {
-      throw new Error(`invalid alpha tester wallet address <${wallet}>`);
+  if (alpha_testers !== undefined) {
+    for (const wallet of alpha_testers) {
+      try {
+        void new PublicKey(wallet.address);
+      } catch (e: unknown) {
+        throw new Error(`invalid alpha tester wallet address <${wallet}>`);
+      }
     }
-  }
 
-  if (alpha_testers.size > 10) {
-    throw new Error(`Alpha testers are limited to 10 per app submission`);
+    if (alpha_testers.size > 10) {
+      throw new Error(`Alpha testers are limited to 10 per app submission`);
+    }
   }
 
   return config;

diff --git a/packages/core/src/publish/PublishCoreSubmit.ts b/packages/core/src/publish/PublishCoreSubmit.ts
@@ -111,7 +111,7 @@ const createSubmitRequest = async (
     );
   }
 
-  if (solanaMobileDappPublisherPortalDetails.alpha_testers.length > 0) {
+  if (solanaMobileDappPublisherPortalDetails.alpha_testers !== undefined && solanaMobileDappPublisherPortalDetails.alpha_testers.length > 0) {
     request.fields.push({
       objectTypeId: TICKET_OBJECT_ID,
       name: TICKET_PROPERTY_ALPHA_TESTERS,

diff --git a/packages/core/src/publish/PublishCoreUpdate.ts b/packages/core/src/publish/PublishCoreUpdate.ts
@@ -114,7 +114,7 @@ const createUpdateRequest = async (
     );
   }
 
-  if (solanaMobileDappPublisherPortalDetails.alpha_testers.length > 0) {
+  if (solanaMobileDappPublisherPortalDetails.alpha_testers !== undefined && solanaMobileDappPublisherPortalDetails.alpha_testers.length > 0) {
     request.fields.push({
       objectTypeId: TICKET_OBJECT_ID,
       name: TICKET_PROPERTY_ALPHA_TESTERS,